Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: slashing release #311

Draft
wants to merge 30 commits into
base: dev
Choose a base branch
from
Draft

feat: slashing release #311

wants to merge 30 commits into from
+4,256 −1,483

Conversation

stevennevins
Copy link
Collaborator

No description provided.

gpsanant and others added 19 commits July 17, 2024 11:42
@gpsanant
Update LICENSE (#285)
7d49b51
@stevennevins
chore: upgrade core to target operator set release
163f4c3
@stevennevins
Merge branch 'dev' into feat/operate-set-release-branch
ad64a45
@shrimalmadhur
chore: update mock contracts with latest interfaces (#293)
b7f4903 
* chore: update mock contracts with latest interfaces
@stevennevins
chore: bump to latest operator set release commits
d991827
@stevennevins
chore: fixes for depedency bump
4966813
@stevennevins
feat: operator set migration-1-migration (#286)
4fabf80 
* chore: checkout migration branch

* feat: implement migration function

* chore: update to release branch

* feat: operator set creation for each quorum number

* feat: migration with merge sorted array of operators and their quorums

* feat: operator set migration working

* chore: revert change from testing

* chore: revert change from testing

* chore: remove extra logging and commented out asserts

* chore: remove unused file

* fix: remove console logs

* refactor: to view functions

* chore: nit and remove unneeded function

* fix: remove duplication of looping for all the operators

* chore: remove comment

* feat: allow migrating in two transactions

* feat: finalization of migration

* chore: use string errors and fix migration issues

* chore: rename

* feat: use library for merge sort

* test: fuzz view function
@stevennevins
feat: operator set migration-2-create quorum (#287)
fe93ac6 
* chore: checkout migration branch

* feat: implement migration function

* chore: update to release branch

* feat: operator set creation for each quorum number

* feat: migration with merge sorted array of operators and their quorums

* feat: operator set migration working

* chore: revert change from testing

* chore: revert change from testing

* chore: remove extra logging and commented out asserts

* chore: remove unused file

* fix: remove console logs

* feat: create quorum post operator set migration

* test(wip): create quorum test adds new operator set

* test: migration create quorum

* refactor: to view functions

* chore: nit and remove unneeded function

* fix: remove duplication of looping for all the operators

* chore: remove comment

* feat: allow migrating in two transactions

* feat: finalization of migration

* chore: use string errors and fix migration issues

* chore: rename

* feat: use library for merge sort

* test: fuzz view function

* fix: updates from merge

* chore: use interface
@stevennevins
chore: bump operator set release dependency in core
e5b2688
@stevennevins
chore: updates from dependency bump
ec2fdf3
@stevennevins
feat: add natspec
12eda5d
@stevennevins
docs: add natspec
788cd09
@stevennevins
feat: add checks operator was registered for quorums when migrating
d64f4af
@stevennevins
fix: resolve code size issue in RegistryCoordinator
a92d51a
@shrimalmadhur
chore: update to latest core (#299)
32148de 
* chore: update to latest eigenlayer-contracts feat/operator-set-release

* chore: add method to mock
@stevennevins
feat(op sets): update stakes when forceUnregister (#300)
86f0928 
* feat: update stakes handle direct deregistration on AVSDirectory

* test: update stake for quorum if operator directly unregistered from the AVSDirectory

* chore: simplify setup

* chore: simplify setup

* chore: make service manager immutable on stakeRegistry
@stevennevins
merge dev
3e4cb2b
@stevennevins
feat(op sets): register and deregister (#301)
f6ad20e 
* feat: register and deregister to operator sets

* fix: bytecode wrangling

* chore: shorter errors to reduce bytecode

* test: register after migration

* chore: remove stale todos

* chore: add back commented line

* chore: remain consistent with m2 events

* fix: side effect of merge from _deregister function

* fix: bytecode massaging

* chore: rename for clarity

* chore: remove comments and whitespace

* docs: add natspec to the library
@stevennevins
feat(op sets): upgrade and migrate script (#303)
e0a79f1 
* feat: upgrade and test pre prod upgrade and migration

* fix: add param introduced in merge
@stevennevins stevennevins changed the title Feat/slashing release branch feat: slashing release Oct 17, 2024
@stevennevins
chore: bump slashing core dependency (#312)
eb0d6ad 
* chore: bump to slashing branch

* chore: bump compiler version

* fix: dep interface changes

* fix: compiler errors from interface changes and type changes

* fix: compiler errors

* chore: bump dependencies

* chore: bump core dependency and resolve issues

* chore: bump core dependency and fix compiler errors

* feat: integrate AllocationManager

* feat: add a slashing permission to the service manager

* chore: remove unneeded casting

* feat: implement a slasher permission and forward call to AllocationManager

* feat: add simiple slasher starting point

* chore: bump slashing magnitudes

* chore: bump core slashing-magnitudes branch
@stevennevins
feat: slasher templates / examples (#310)
cb4df12 
* chore: bump to slashing branch

* chore: bump compiler version

* fix: dep interface changes

* fix: compiler errors from interface changes and type changes

* fix: compiler errors

* chore: bump dependencies

* chore: bump core dependency and resolve issues

* chore: bump core dependency and fix compiler errors

* feat: integrate AllocationManager

* feat: add a slashing permission to the service manager

* chore: remove unneeded casting

* feat: implement a slasher permission and forward call to AllocationManager

* feat: add simiple slasher starting point

* feat: slashers

* chore: change around slashed event

* fix: call dm

* feat: add proposal mechanism for updating slasher

* fix: set to completed instead of delete

* chore: use struct instead of params directly

* chore: clean up params more

* chore: simplify and organize files

* chore: cleanup logic and couple event with internal func

* fix: pass correct params

* chore: organize and add interface

* chore: nits

* chore: cleanup more nits

* fix: storage gap

* chore: nits refactor

* chore: go back to fulfill being onlySlasher

* test: fixes from core updates

* fix: use delegated stake per operator set instead of per AVS

* fix: update to 14 days

* feat: configurable lookahead and stake type
wadealexc
wadealexc reviewed Nov 8, 2024
View reviewed changes
src/StakeRegistry.sol Outdated Show resolved Hide resolved
stevennevins and others added 4 commits November 18, 2024 13:52
@stevennevins
chore: remove unused test util contracts (#319)
145bdaf 
* feat: remove both option

* chore: remove unused test util contracts

* chore: remove diff
@stevennevins
feat: remove both option
9a975df
@stevennevins
fix: storage gap remove one slot (#320)
fa04f06
@stevennevins
feat: track total slashable stake and total delegated stake per quorum (
388e9f9 
#317)

* feat: remove both option

* feat: total delegated stake and total slashable stake per quorum config

* test: resolve some breaking changes to tests

* chore: move stake type to file level definition

* chore: refactor loop

* test: add unit test for slashble stake quorum init

* test: assert on state and event

* test: delegated stake quorum and assertions
@supernovahs
Copy link 

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from contract TransparentUpgradeableProxy to contract ITransparentUpgradeableProxy requested.
   --> lib/eigenlayer-middleware/test/utils/MockAVSDeployer.sol:310:17:
    |
310 |                 TransparentUpgradeableProxy(payable(address(registryCoordinator))),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error: Compilation failed

getitng this while compiling my contracts in IS with this as submodule

supernovahs
supernovahs reviewed Dec 4, 2024
View reviewed changes
test/mocks/ECDSAServiceManagerMock.sol
Comment on lines +33 to +39
function registerOperatorToOperatorSets(
address operator,
uint32[] calldata operatorSetIds,
ISignatureUtils.SignatureWithSaltAndExpiry memory operatorSignature
) external {}

function deregisterOperatorFromOperatorSets(address operator, uint32[] calldata operatorSetIds) external{}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be directly called by the operator right? Or is it necessary to route these through service manager?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have to be routed through the service manager currently, but that will likely change post-UAM

They won't be called directly by the operator on the service manager, though. The flow would be

Registry -> ServiceManager -> AllocationManager

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is UAM?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

universal access managemnent

supernovahs
supernovahs reviewed Dec 4, 2024
View reviewed changes
Copy link

@supernovahs supernovahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@stevennevins
Copy link
Collaborator Author 

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from contract TransparentUpgradeableProxy to contract ITransparentUpgradeableProxy requested.
   --> lib/eigenlayer-middleware/test/utils/MockAVSDeployer.sol:310:17:
    |
310 |                 TransparentUpgradeableProxy(payable(address(registryCoordinator))),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error: Compilation failed

getitng this while compiling my contracts in IS with this as submodule

I wonder if your remappings for openzeppelin are pointing to a different version than in this repo

stevennevins and others added 5 commits December 4, 2024 11:58
@stevennevins
fix: use libraries with only internal vis (#324)
158a890 
* fix: revert making library function vis external

* fix: signature checker internal
@stevennevins
feat: avs registrar registration flow changes (#318)
817ad42 
* feat: remove both option

* feat: total delegated stake and total slashable stake per quorum config

* test: resolve some breaking changes to tests

* chore: bump core dependency

* chore: bump dependency

* chore: bump to latest slashing mags

* fix: creation of registry coordinator

* test: wip

* feat: integrate registrar interfaces

* test: add function to delegation mock to set operator status

* test: additional test case

* chore: bumping core dep and adding UAM (#325)

* test: use permission controller mock

* chore: label fuzz tests

* test: various fixes from config changes

* chore: remove comment

* test: fix permission controlled functions

* test: fix config issue in integration tests

* test: fix avs directory initialize

* feat: wip prevent m2 registration flows after migration
@stevennevins
feat: registration changes part 2
dbd59dd 
* chore: add note

* fix: remove handling of forceDeregistration

* fix: fix total delegated stake usage

* fix: integration tests

* test: fix remaining integration tests

* test: add back log check

* test: add additional tests for transition to operator sets

* test: add more test cases

* feat: record m2 quorums on migration

* chore: add note about churn support

* fix: prevent operator set registration changes for m2 quorums

* feat: require strings

* chore: add dev note and add require string
@stevennevins
chore: bump dependency for slashing mags updates (#329)
6fd466e
@nadir-akhtar
Merge branch 'mainnet' into feat/slashing-release-branch
f9ce2fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supernovahs supernovahs supernovahs left review comments

@wadealexc wadealexc wadealexc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stevennevins @supernovahs @wadealexc @gpsanant @shrimalmadhur @nadir-akhtar