feat: operator sets #607

ypatil12 · 2024-07-01T15:31:42Z

Pending Performance Based Rewards

src/contracts/core/AVSDirectoryStorage.sol

src/contracts/core/AVSDirectory.sol

src/contracts/core/AVSDirectoryStorage.sol

src/contracts/core/AVSDirectory.sol

src/contracts/interfaces/IAVSDirectory.sol

src/contracts/core/AVSDirectory.sol

wadealexc

One of the usecases is:

As an AVS, I would like to distinguish between the strategies in each of my operator sets on the UI

I don't see strategies represented super well with these operator sets.

There's no clear "create operator set" method (yes, it can be in the middleware contracts, but I'm questioning why we don't have an explicit creation method here)
There's no clear binding between an operator set and the strategies it represents

src/contracts/core/AVSDirectory.sol

0xClandestine · 2024-07-09T18:40:21Z

Was able to condense 4 mappings into 2 with the recent storage overhaul, it allows for the original interface if we want to add some getters.

Saves several SLOADs/SSTOREs throughout AVSDirectory.

src/contracts/core/RewardsCoordinatorStorage.sol

src/contracts/core/AVSDirectory.sol

8sunyuan · 2024-07-26T14:59:49Z

src/contracts/core/AVSDirectory.sol

+     * @dev The AVS may create operator sets before it becomes an operator set AVS.
+     */
+    function createOperatorSets(uint32[] calldata operatorSetIds) external {
+        for (uint256 i = 0; i < operatorSetIds.length; ++i) {


Can we have another pause flag for this function?

Not sure why we would ever pause this?

src/contracts/core/AVSDirectory.sol

src/contracts/core/AVSDirectoryStorage.sol

#636) * feat: bring back full storage; segregate events * feat: make operator set creation w/arrays; update interface * fix: update natspec * feat: update force dereg func * chore: fmt * feat: operator set migration (#637) * feat: add migration * test: add unit tests for migration * chore: format * fix: check operator set avs in parent func * fix: compilation * chore: format * feat: bring back opertor set struct (#639)

* feat: operator commission bips configured with a delay * build: bindings * fix: interfaces and comments * fix: storage gap and comments * chore: tests cleanup * build: bindings * chore: `forge fmt src/contracts` * feat: `operatorCommissionUpdates` length getter * fix: remove unused imports * fix: optimizations * chore: uncheckeds and remove dup view * build: bindings * chore: format --------- Co-authored-by: clandestine.eth <[email protected]>

also pushed updated bindings

* feat: track total members and sets * test: track total members and sets * fix: review changes * refactor: review changes * test: register multiple sets * test: deregister multiple sets * test: fuzz set creation

* feat: operator set rewards * chore: forge fmt * feat: add operator set retroactive length & genesis timestamp * docs: add deprecation note and fix typo * build: bindings * feat: add tests * chore: bindings --------- Co-authored-by: clandestine.eth <[email protected]> Co-authored-by: Michael Sun <[email protected]>

* fix: flakey tests * build: bindings * fix: out of gas error

* feat: track sets operators in * feat: add natspec * refactor: reorganize * fix: tests passing * fix: compile warnings * fix: test passing * feat: add `operatorSetsMemberOf` pagination * test: add coverage * chore: bindings --------- Co-authored-by: Yash Patil <[email protected]>

* fix: prevent opSet AVS from m2 dereg * fix: naming

* feat: functionality * test: add tests * chore: address comments * chore: bindigns and fmt

github-actions · 2024-08-29T16:17:32Z

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          | 100%    89| 100%  29|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |94.6%   148|88.6%  35|    -    0
core/StrategyManager.sol                       |97.6%    83| 100%  24|    -    0
libraries/BeaconChainProofs.sol                | 100%    22| 100%  11|    -    0
libraries/BytesLib.sol                         | 0.0%   156| 0.0%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/EigenPod.sol                              | 100%   122|96.2%  26|    -    0
pods/EigenPodManager.sol                       | 100%    75|92.9%  14|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   5|    -    0
strategies/StrategyBase.sol                    |90.9%    44|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12| 100%   6|    -    0
strategies/StrategyFactory.sol                 | 100%    35| 100%   9|    -    0
token/BackingEigen.sol                         |80.0%    25|60.0%  10|    -    0
token/Eigen.sol                                |43.6%    39|58.3%  12|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|77.6%  1187|78.3% 300|    -    0

ypatil12 · 2024-08-29T20:23:59Z

Combined with slashing: #679

ypatil12 marked this pull request as draft July 1, 2024 15:32

wadealexc changed the title ~~Feat: Operator Sets~~ feat: operator sets Jul 1, 2024