Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

payments - global reservation uses interval config #980

Merged
merged 1 commit into from
Dec 12, 2024
Merged

payments - global reservation uses interval config #980

merged 1 commit into from
Dec 12, 2024
+14 −25

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 11, 2024

Why are these changes needed?

Utilize the global rate reservation interval to make relative global index instead of directly using timestamps

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen force-pushed the hope/payments-minor-fixes branch from 45741aa to df4c330 Compare December 12, 2024 17:34
@hopeyen hopeyen requested a review from ian-shim December 12, 2024 18:20
@hopeyen hopeyen merged commit 6588b33 into master Dec 12, 2024
9 checks passed
@hopeyen hopeyen deleted the hope/payments-minor-fixes branch December 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeyen @ian-shim