Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cumulative payment units #937

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

cumulative payment units #937

wants to merge 17 commits into from

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Nov 26, 2024

Why are these changes needed?

Keep it consistent with the contracts

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen mentioned this pull request Nov 26, 2024
5 tasks
Base automatically changed from hope/v2-payments to master December 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant