Keep encoded blob result until blob reaches terminal state #750
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
keep-encoded-res-until-terminal
branch
3 times, most recently
from
a876418 to
1618080
Compare
bxue-l2
reviewed
Sep 6, 2024
disperser/batcher/batcher.go
Outdated
| @@ -312,10 +312,12 @@ func (b *Batcher) updateConfirmationInfo( | |||
|
|
|||
| if status == disperser.Confirmed { | |||
| if _, updateConfirmationInfoErr = b.Queue.MarkBlobConfirmed(ctx, metadata, confirmationInfo); updateConfirmationInfoErr == nil { | |||
| b.EncodingStreamer.RemoveEncodedBlob(metadata) | |||
There was a problem hiding this comment.
what is the chance of memory leak, when it falls into the last else statement part. CAn we just remove it regardless of the "if" condition
There was a problem hiding this comment.
in addition to that. the memory load on the batcher for 600sec batch interval would be 10MB/s*600 = 6GB. It looks manageable
There was a problem hiding this comment.
Sg, removing regardless of the if condition seems benign
ian-shim
force-pushed
the
keep-encoded-res-until-terminal
branch
from
1618080 to
d51fa10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, the encoded blob result is removed once blob state transitions from
PROCESSINGtoDISPERSING.However, a blob can be fetched for encoding and then be transitioned to
DISPERSINGstate before the encoding request is complete because the mutex is released and allows the blob to be returned as part of a batch.This can cause an issue where the blob is successfully confirmed, but the remaining encoding result causes the blob to be dispersed again. The encoded blob state management needs to be enforced more tightly.
This PR does not remove the encoded result when it's returned as part of the batch. Instead, it keeps it until the blob reaches a terminal state so that it can be properly dedup'd from the concurrent encoding requests.
Checks