Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to guzzle 6 #20

Closed
wants to merge 14 commits into from
Closed

upgrade to guzzle 6 #20

wants to merge 14 commits into from

Conversation

bendavies
Copy link
Contributor

ref #16

This is WIP.

I had to remove the commerce guys oauth2 plugin as it is incompatible with guzzle 6

TODO:

  • reintroduce xml support - this is not trivial. the json and xml serializations from jms serializer a not really similar (xml has attributes etc...), so it's not trivial to convert both json and xml to a standard array format.
  • Update readme.
  • ???

use GuzzleHttp\Message\ResponseInterface;
use GuzzleHttp\Url;
use GuzzleHttp\Event\SubscriberInterface;
use GuzzleHttp\Psr7\Uri;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of typehintnig with URI implementation from Guzzle library, I would suggest to use an UriInterface from Psr\Http\Message namespace.

@gruberro
Copy link

How about using Sainsburys Guzzle6-port for the oauth2 plugin?

@owsy owsy closed this by deleting the head repository Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants