-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to guzzle 6 #20
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for using query parameters to get()
add method to do a PUT
src/ClientInterface.php
Outdated
use GuzzleHttp\Message\ResponseInterface; | ||
use GuzzleHttp\Url; | ||
use GuzzleHttp\Event\SubscriberInterface; | ||
use GuzzleHttp\Psr7\Uri; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of typehintnig with URI implementation from Guzzle library, I would suggest to use an UriInterface from Psr\Http\Message
namespace.
allow initializing paginator to a specific page
How about using Sainsburys Guzzle6-port for the oauth2 plugin? |
add async support to client
add async support to api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #16
This is WIP.
I had to remove the commerce guys oauth2 plugin as it is incompatible with guzzle 6
TODO: