Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle 6 #16

Open
bendavies opened this issue Jan 14, 2016 · 4 comments
Open

Guzzle 6 #16

bendavies opened this issue Jan 14, 2016 · 4 comments

Comments

@bendavies
Copy link
Contributor

Hey,

I notice this library is constrained to guzzle 5 because that is what the oauth subscriber supports.
Personally i'm not using oauth to authenticate my sylius based api, so this is a shame for me that i'm constrained to guzzle 5.

There is no guzzle 6 oauth2 subscriber unfortunately, so upgrading is not trivial.

Is there any appetite to get this library working with guzzle 6?
This would require a new subscriber or upgrading commerce guys.

I don't have much motivation to do this however, as I'm not using oauth2...

@bendavies
Copy link
Contributor Author

@pjedrzejewski just wondered, was there a discussion about not using oauth2 for the sylius api? i seem to remember reading something but can't find it now

@bendavies
Copy link
Contributor Author

@michalmarcinkowski maybe we can maintain 2 branches here, one for guzzle 5 and one for 6?

@michalmarcinkowski
Copy link
Member

@bendavies I added guzzle-6 branch, feel free to open a PR with changes necessary to make it work with Guzzle 6.

@bendavies
Copy link
Contributor Author

Then issue is that we can't use the current oauth2 subscriber with guzzle6. So i wouldy remove it as a dependency.

@bendavies bendavies mentioned this issue Jan 19, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants