RFC-0002: Remove filter_state from the explicitly supported attributes #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,7 +76,7 @@ These two subsets of attributes are unified into a single set of well-known attr | |||
| The next sections specify the well-known attributes organized in the following groups: | |||
| - [Request attributes](#request-attributes) | |||
| - [Connection attributes](#connection-attributes) | |||
| - [Metadata and filter state attributes](#metadata-and-filter-state-attributes) | |||
| - [Metadata attribute](#metadata-and-filter-state-attributes) | |||
There was a problem hiding this comment.
Suggested change
| - [Metadata attribute](#metadata-and-filter-state-attributes) | |
| - [Metadata attribute](#metadata-attribute) |
There was a problem hiding this comment.
Although arguably the metadata attribute (singular) gives you a collection of other (not so well-known) attributes and values (plural.) So I wouldn't mind calling this section Metadata attributes if you want.
There was a problem hiding this comment.
I've kept the anchor unchanged
As mentioned above, I had left the anchor unchanged, so that anything referencing that part wouldn't result in a broken link... So what do we do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've kept the anchor unchanged