RFC 00010 distributed DNS #70
Conversation
|
Couple of questions/thoughts, but nothing major. /lgtm |
|
@ficap I think your change requests are complete now |
rfcs/0008-distributed-dns.md
Outdated
| When a DNSRecord is being removed, the following must be successfully completed before the finalizer can be removed: | ||
| - Remove the local clusters records and targets from the relevant zone | ||
| - Perform a prune on the relevant root host | ||
| - Apply the results of the prune to the DNS Provider |
There was a problem hiding this comment.
also delete healthchecks if needed (how to detect it - no records left?)
There was a problem hiding this comment.
This is a good point. @philbrookes any thoughts on when we delete a health check? I would think it is part of the dead end check? IE if there is no endpoints for a given rootHost then remove?
There was a problem hiding this comment.
had to change the rfc number which is why this shows as outdated
There was a problem hiding this comment.
@ficap I have updated this now. Note I had to change the file name due to the rfc number changing
|
@philbrookes I noticed rfc 8 is already on main while looking through a couple other prs https://github.com/Kuadrant/architecture/blob/main/rfcs/0008-kuadrant-release-process.md |
Co-authored-by: Craig Brookes <[email protected]>
Co-authored-by: Filip Cap <[email protected]>
maleck13
force-pushed
the
update-rfc-0008
branch
from
31e5dc2 to
bfea792
Compare
maleck13
changed the title
|
@maleck13 I think it would be also beneficial to list here all cases that can happen during plan creation and how they should be resolved. So that we can discuss possible ambiguous cases prior to implementation here. |
Can you give an example of what you are expecting |
Something like the "use cases to ensure" in this issue Kuadrant/dns-operator#49 . Basically have a set of rules that would apply during plan creation. |
| @@ -0,0 +1,291 @@ | |||
| # Distributed DNS Load Balancing | |||
There was a problem hiding this comment.
'0009' already taken.
Replaces #55