Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plotInset parameter to style #431

Merged
merged 9 commits into from
Sep 4, 2024

Conversation

lucas-watkins
Copy link

Try to close #406

@AndreiKingsley AndreiKingsley changed the base branch from main to dev September 3, 2024 20:36
@AndreiKingsley
Copy link
Collaborator

Looks like Inset class is a basically the same as Margin. So, may be we don't need another class here, only property/function names.

@@ -70,6 +70,33 @@ public interface WithMargin {
}
}

public data class Inset(val top: Double, val right: Double, val bottom: Double, val left: Double) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the same as Margin

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, would a typealias be acceptable here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@AndreiKingsley AndreiKingsley merged commit aaf638e into Kotlin:dev Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plotInset parameter to style
2 participants