Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reviewers for dependabot - 'assignees' is only for individuals #1935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

sigh I can't read.

assignees => https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#assignees

Use assignees to specify individual assignees for all pull requests raised for a package manager.

reviewers ==> https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#reviewers

Use reviewers to specify individual reviewers or teams of reviewers for all pull requests raised for a package manager. You must use the full team name, including the organization, as if you were @mentioning the team.

Issue: "none"

Test plan:

@jeremywiebe jeremywiebe self-assigned this Nov 29, 2024
@jeremywiebe jeremywiebe marked this pull request as ready for review November 29, 2024 21:01
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .github/dependabot.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team November 29, 2024 21:01
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (a6be097) and published it to npm. You
can install it using the tag PR1935.

Example:

yarn add @khanacademy/perseus@PR1935

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1935

Copy link
Contributor

Size Change: 0 B

Total Size: 1.29 MB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 697 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 422 kB
packages/perseus/dist/es/strings.js 3.68 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@@ -12,8 +12,8 @@ updates:
- dependency-name: "@khanacademy/eslint-plugin"
- dependency-name: "@khanacademy/wonder-blocks-*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be useful adding Khan/wonder-blocks for reviewing these changes? I'm not sure if that would be a good signal for us to know when we can update the webapp repo to have synced deps? or do you recommend something different?

How do you think the process should work now that dependabot is connected for these type of updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants