Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLT Support #168

Open
jihanesaadeh opened this issue Jan 30, 2017 · 10 comments
Open

RLT Support #168

jihanesaadeh opened this issue Jan 30, 2017 · 10 comments

Comments

@jihanesaadeh
Copy link

Hello,

I'm working on a multi-lingual website. Does the Liquid Slider support rtl websites?

Thanks,
Jihane

@KevinBatdorf
Copy link
Owner

Do you mean like, if you click the right arrow it will move to the left slide? If so, then no, but you could program the arrows outside of the slider using the custom controls

@jihanesaadeh
Copy link
Author

I mean when I'm changing the language to Arabic, and direction to rtl (as follow):

the slider totally disappears from my page.

@KevinBatdorf
Copy link
Owner

I'd have to see an example. Do you have it online somewhere?

@jihanesaadeh
Copy link
Author

Hello,

I've uploaded a WIP version:
http://216.172.166.19/~upload/jihane/index.html

Thank you,
Jihane

@KevinBatdorf
Copy link
Owner

Seems there's a javascript error on the page from jquery history. It might be unrelated but that stops other code from firing off

@jsaade
Copy link

jsaade commented Feb 2, 2017

If you have a direction=rtl tag on elements (div, body, etc..) liquid slider does not work and renders blank image with correct height.
@KevinBatdorf do you have a working RTL example?

Thanks

@KevinBatdorf
Copy link
Owner

I don't have a working example. But if you have a non-working one I can try to debug why it's not working.

@BackuPs
Copy link

BackuPs commented Oct 8, 2024

I have the same problem on rtl the content of the tabs is not shown because of this js

`

(_this.panelContainer).css({
'-webkit-transform': 'translate3d(' + marginLeft + _this.pSign + ', 0, 0)',
'-moz-transform': 'translate3d(' + marginLeft + _this.pSign + ', 0, 0)',
'-ms-transform': 'translate3d(' + marginLeft + _this.pSign + ', 0, 0)',
'-o-transform': 'translate3d(' + marginLeft + _this.pSign + ', 0, 0)',
'transform': 'translate3d(' + marginLeft + _this.pSign + ', 0, 0)'
});

`

@KevinBatdorf
Copy link
Owner

@BackuPs This plugin hasn't been updated in many years, but if you want to share a link to your site maybe I can give a tip. There's probably better plugins to use though...

@BackuPs
Copy link

BackuPs commented Oct 8, 2024

The solution is simple change this function

`

LiquidSlider.getTransitionMargin = function() {
  var _this = this;

  var rtl = jQuery('body' ).hasClass('rtl')

  if (rtl)  return ( 100 - ( ( _this.nextPanel + 1) * _this.slideDistance) ) -
	(_this.slideDistance * ~~(_this.options.continuous));

  return -(_this.nextPanel * _this.slideDistance) -
	(_this.slideDistance * ~~(_this.options.continuous));
};

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants