Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: pass logger to go-tarantool #79

Open
nurzhan-saktaganov opened this issue Sep 19, 2024 · 0 comments · May be fixed by #86
Open

Logging: pass logger to go-tarantool #79

nurzhan-saktaganov opened this issue Sep 19, 2024 · 0 comments · May be fixed by #86
Labels
enhancement New feature or request future/nsaktaganov merged to future/nsaktaganov

Comments

@nurzhan-saktaganov
Copy link
Collaborator

go-tarantool writes logs by default to stderr. Stderr might be not available, or user might use syslog or logging into file.
So we should implement logging interface and redirect go-tarantool logs to the user's logger.
@nurzhan-saktaganov nurzhan-saktaganov added the enhancement New feature or request label Sep 19, 2024
nurzhan-saktaganov added a commit that referenced this issue Sep 24, 2024
@nurzhan-saktaganov
resolve issue #79
c548cde 
* implement go-tarantool Logger interface to use the same logger as router uses
* AddInstance bugfix: pass r.cfg.PoolOpts to new instance
nurzhan-saktaganov added a commit that referenced this issue Sep 24, 2024
@nurzhan-saktaganov
resolve issue #79
c72023c 
* implement go-tarantool Logger interface to use the same logger as router uses
* AddInstance bugfix: pass r.cfg.PoolOpts to new instance
nurzhan-saktaganov added a commit that referenced this issue Sep 24, 2024
@nurzhan-saktaganov
resolve issue #79
16d2527 
* implement go-tarantool Logger interface to use the same logger as router uses
* AddInstance bugfix: pass r.cfg.PoolOpts to new instance
@nurzhan-saktaganov nurzhan-saktaganov linked a pull request Sep 24, 2024 that will close this issue
WIP: resolve issue #79 #86
Draft
nurzhan-saktaganov added a commit that referenced this issue Sep 24, 2024
@nurzhan-saktaganov
resolve issue #79
a96a063 
* implement go-tarantool Logger interface to use the same logger as router uses
* AddInstance bugfix: pass r.cfg.PoolOpts to new instance
nurzhan-saktaganov added a commit that referenced this issue Sep 25, 2024
@nurzhan-saktaganov
resolve issue #79
d27ded0 
* implement go-tarantool Logger interface to use the same logger as router uses
* AddInstance bugfix: pass r.cfg.PoolOpts to new instance
@nurzhan-saktaganov nurzhan-saktaganov added the future/nsaktaganov merged to future/nsaktaganov label Oct 8, 2024
nurzhan-saktaganov added a commit that referenced this issue Oct 8, 2024
@nurzhan-saktaganov
resolve issue #79
6e9ac2d 
* implement go-tarantool Logger interface to use the same logger as router uses
* AddInstance bugfix: pass r.cfg.PoolOpts to new instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request future/nsaktaganov merged to future/nsaktaganov
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: resolve issue #79 KaymeKaydex/go-vshard-router
1 participant
@nurzhan-saktaganov