Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and improve docs for nested packages #4

Open
4 tasks
vostrik opened this issue Jul 4, 2023 · 1 comment
Open
4 tasks

Review and improve docs for nested packages #4

vostrik opened this issue Jul 4, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@vostrik
Copy link
Collaborator

vostrik commented Jul 4, 2023

It is more useful to get quick start information in each package README file:

  • components-v6
  • runtime
  • ui-builder
  • dev-tools
@vostrik vostrik self-assigned this Jul 4, 2023
@vostrik vostrik added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Jul 4, 2023
@vostrik vostrik added this to UIF Jul 4, 2023
@vostrik vostrik removed their assignment Jul 4, 2023
@vostrik vostrik moved this to 📋 Backlog in UIF Jul 4, 2023
@mikegsrv
Copy link

Hi!

Spend some time reviewing docs for kl-dev-tools and can suggest improvements on issues below:

Line 26: suggestion: Seems like it's possible to use ENV variables to define tsconfigRootDir and fallback to __dirname if nothing found. My idea based on the assumption that this is provided as package. IMO – packages might not be changed based from proj to proj, so defining env may bring some good changes.

Line 34: typo: extra space after the header, break markdown.

Line 36: suggestion: it would be great to add peerDependenciesMeta field for those on this requirements.

Line 48: issue: it's hard to understand what is 'shared package' in this context and why one may add it. This topic definitely needs improvement. Also it seems like both sections (see link above) are similar to each other at first sight. As far as I understood – shared config is more like an internal ability to expand package, but not applicable for open-source solution. However, config extension is the section one may want to publish. Definitely need some discussion on this topic.

Line 64: question: this one has no any description on why one should use this script. IMO, it can be done as a binary with 'post-install' script for example with user prompt on version? But this is far away from the docs problems. :)

Line 72: question: similar question as the previous point: maybe it's possible to use some kind of 'setup-scripts' to make less user interactions and improve DevExp?

– General: nitpick: README lacks description about all the using configs (take a look – a lot of sections on ESLint, but almost nothing on jest / ts / babel). Hard to understand why project even needs this package. Something like an abstract in the beginning will do.

Therefore, I would like to make some cleaning on this part of docs. I would like to know, what exactly can be changed and what should stay as is so I could propose changes for you to review.

Best wishes,
Mike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants