Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible returned duplicate #352

Open
DJTB opened this issue Dec 5, 2017 · 5 comments
Open

Possible returned duplicate #352

DJTB opened this issue Dec 5, 2017 · 5 comments

Comments

@DJTB
Copy link
Collaborator

DJTB commented Dec 5, 2017

not sure if this was cleared and has reappeared, or if it was just never cleared.
on Tadgh staging account

{
  "id": 8979481,
  "vocabulary": {
    "id": 305,
    "meaning": "times, number of times, time",
    "readings": [
      {
        "id": 320,
        "character": "回",
        "kana": "かい",
        "level": 5,
        "sentence_en": null,
        "sentence_ja": null,
        "common": null,
        "furigana": null,
        "pitch": null,
        "parts_of_speech": []
      },
      {
        "id": 5519,
        "character": "〜回",
        "kana": "かい",
        "level": 5,
        "sentence_en": "I’ve been to Japan once.",
        "sentence_ja": "日本に一回行ったことがあります",
        "common": true,
        "furigana": "1:かい",
        "pitch": null,
        "parts_of_speech": [
          "ctr"
        ]
      }
    ]
  },
}

id 320 shouldn't exist
WK changed 回 to 〜回 at some point

may be related to #345

@tadgh
Copy link
Collaborator

tadgh commented Dec 5, 2017

nope i just havent looked into it yet

@DJTB
Copy link
Collaborator Author

DJTB commented Dec 9, 2017

Some other vocab items for testing duplicate/merger stuff from WK blog.
Note the "scheduled for removal" items - think that's the first we've seen for complete removal.

As of week ending Dec 9
洋服 - Changed primary meaning to “clothes” and added to meaning explanation
苦しむ - Removed “to hurt” and added “to struggle” to meanings
便利 - Added “useful” to meanings
別の - Removed “noun” from meanings
別人 - Changed primary meaning to “different person” and removed “new man” and “different man”
命 - Removed “life force” from meanings
心持 - Changed to 心持ち (more contemporary spelling)
文章 - Added “writing” and made primary reading, added to explanation
面 - Made private - scheduled for removal
堀川 - Made private - scheduled for removal
相図 - Made private - scheduled for removal

@tadgh
Copy link
Collaborator

tadgh commented Dec 10, 2017

interesting. we will definitely have to delete vocabulary which are removed manually. i'm not too concerned if readings get removed.

@DJTB
Copy link
Collaborator Author

DJTB commented Dec 16, 2017

As of 16 Dec, noticed 女性 changed from female to female, woman, lady

@tadgh
Copy link
Collaborator

tadgh commented Dec 18, 2017

I'm gonna backlog this for now. I will handle removing stale readings at a later date, wince this is what this is, roughly .

@tadgh tadgh added the backlog label Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants