Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived FSM style functions have lots of room for optimizations #163

Open
JulianKemmerer opened this issue Feb 7, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@JulianKemmerer
Copy link
Owner

Want a pass that can combine sequential-looking FSM states that occur in the same cycle into one/as few combintatorial state transitions as possible (watching out for states that can't be jumped to / combined to others)

Then the parallel state grouping in C_AST_FSM_FUNDEF_BODY_TO_LOGIC and GET_GROUPED_STATE_TRANSITIONS seems like it has room for improvement, especially regarding ordering of inlined subroutine states vs single instance fsm module connection entry+FSM+exit triple state sequence.

@JulianKemmerer JulianKemmerer added the enhancement New feature or request label Feb 7, 2023
@JulianKemmerer
Copy link
Owner Author

Gah, made this issue thinking it shouldnt block whats in #86

But in testing it seems the rework that makes #86 almost done does need some ~optimization (not funcitonal) changes to meet timing in some of the old tests... so I guess addressing this issue too maybe...

@JulianKemmerer JulianKemmerer self-assigned this Feb 8, 2023
@JulianKemmerer
Copy link
Owner Author

Actually will probably not require this change right away with #86 and can instead do at leisure when using results of combined #86 and instance array wires branch to do cool things

@JulianKemmerer JulianKemmerer removed their assignment Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant