Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Symbolics to 6 for package test, (keep existing compat) #3634

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Symbolics package from 1 - 5 to 1 - 5, 6 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-08-12-00-44-13-656-03377107050 branch from eb0aed3 to cc9a394 Compare August 12, 2024 00:44
@schillic
Copy link
Member

schillic commented Aug 12, 2024

x-ref #3635
The new version of Symbolics breaks the nice parsing of expressions that we use it for:
Hyperplane(2x + 3y == 5) now becomes Hyperplane([3.0, 2.0], 5.0).
I had asked for a way to get the sorted variables a while ago, but so far there is no solution. Until then, this PR is on hold.

@schillic schillic marked this pull request as draft August 12, 2024 15:30
@schillic schillic deleted the compathelper/new_version/2024-08-12-00-44-13-656-03377107050 branch August 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant