Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_redundant_constraints should not return an EmptySet #3160

Open
schillic opened this issue Oct 30, 2022 · 0 comments
Open

remove_redundant_constraints should not return an EmptySet #3160

schillic opened this issue Oct 30, 2022 · 0 comments
Labels
breaking ❌ This change may break things discussion 🗣️ Requires human input performance 🐎 More efficient code

Comments

@schillic
Copy link
Member

Currently remove_redundant_constraints returns a list of constraints if it was successful and an EmptySet otherwise. This is type unstable and also does not make much sense. Instead it can return an empty list of constraints.
@schillic schillic added discussion 🗣️ Requires human input performance 🐎 More efficient code breaking ❌ This change may break things labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking ❌ This change may break things discussion 🗣️ Requires human input performance 🐎 More efficient code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schillic