Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize plotting to non-convex sets and add some functionality for VPolygonNC #3127

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

schillic
Copy link
Member

@schillic schillic commented Oct 13, 2022

There are no docstrings nor tests (to be added in #3124), but the functions are simple (they were just required for plotting) and I tried plotting manually.

@schillic schillic marked this pull request as ready for review October 14, 2022 05:30
@schillic schillic requested a review from mforets October 14, 2022 05:31
@schillic schillic merged commit ff1f7a1 into master Oct 16, 2022
@schillic schillic deleted the schillic/plot_VPolygonNC branch October 16, 2022 16:36
@David-davidlxl
Copy link

The following code produces an incorrect plot of a nonconvex polygon:

using LazySets
using Plots

polygon = VPolygon([[0, 0],
    [2.1314, 0.9141],
    [1.8282, 1.2219],
    [0.9141, 0.9141],
    [0.6063, 1.5251],
    [-0.6063, 2.1360],
    ], apply_convex_hull=false)

plot(polygon)

Did I plot it incorrectly or is this a bug?

@schillic
Copy link
Member Author

@David-davidlxl: The type was renamed to Polygon.

polygon = Polygon([[0, 0],
    [2.1314, 0.9141],
    [1.8282, 1.2219],
    [0.9141, 0.9141],
    [0.6063, 1.5251],
    [-0.6063, 2.1360]])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants