Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakage on Julia v1.0 #5

Open
jishnub opened this issue Jun 29, 2023 · 6 comments
Open

Breakage on Julia v1.0 #5

jishnub opened this issue Jun 29, 2023 · 6 comments

Comments

@jishnub
Copy link
Contributor

jishnub commented Jun 29, 2023

https://github.com/JuliaMath/IntegerMathUtils.jl/pull/3/files#diff-28602f93a5d315a5d6dfd2d013de41a6b0bcbd3ed01c7ca21dca919edc4b78fbR13 seems to have broken this package on Julia v1.0, since the macro @ccall is not defined. Perhaps the support for v1.0 should be dropped if it isn't supported.

@oscardssmith
Copy link
Member

Good catch. I will bump support to 1.6 since I don't think many people are still using versions less than the LTS.

@jishnub
Copy link
Contributor Author

jishnub commented Jun 29, 2023

I think it'll also be better to update the general registry compat bounds, to make Julia v1.0 use v0.1.0 of this package

@oscardssmith
Copy link
Member

I was just going to yank 0.1.1, but if there's a better way to do it, that would be great.

@jishnub
Copy link
Contributor Author

jishnub commented Jun 29, 2023

Once v0.1.2 is tagged, I can make a PR to the registry

@devmotion
Copy link
Member

To avoid such problems in the future, IMO it would be good to add CI tests and in particular also test Julia 1.6. It seems currently no tests are run on Github?

(I don't know anything about this package but somehow quite a few notifications showed up in my feed 😅)

@oscardssmith
Copy link
Member

yeah. I do need to get CI set up for this package.

jishnub added a commit to jishnub/General that referenced this issue Jun 30, 2023
See the discussion in JuliaMath/IntegerMathUtils.jl#5. The release v0.1.1 does not support Julia v1.0, but the `Project.toml` had not been updated erroneously. This makes the package unusable on Julia v1.0 without restricting its version to v0.1.0
giordano pushed a commit to JuliaRegistries/General that referenced this issue Jul 3, 2023
See the discussion in JuliaMath/IntegerMathUtils.jl#5. The release v0.1.1 does not support Julia v1.0, but the `Project.toml` had not been updated erroneously. This makes the package unusable on Julia v1.0 without restricting its version to v0.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants