Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition and Multiplication between BlockDiagonals not type stable #4

Open
nickrobinson251 opened this issue Apr 26, 2019 · 2 comments
Open

Addition and Multiplication between BlockDiagonals not type stable #4

nickrobinson251 opened this issue Apr 26, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@nickrobinson251
Copy link
Contributor

I think implementing broadcasting will fix this for us, but not totally sure
@nickrobinson251 nickrobinson251 added the help wanted Extra attention is needed label Apr 26, 2019
@nickrobinson251
Copy link
Contributor Author

it is only type unstable between Matrix and the types of the input, which should be a union of less than 4 types... which aparently makes this "not that bad" (using BlockDiagonals will still be a big improvement to users) -- but still, not totally ideal

@nickrobinson251
Copy link
Contributor Author

https://julialang.org/blog/2018/08/union-splitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickrobinson251