Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ApproxFunBaseTest to a package extension #657

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 9, 2024

After this, downstream packages don't need to depend explicitly on ApproxFunBaseTest, but may instead depend on the internal module ApproxFunBase.TestUtils, which is equivalent in functionality. The advantage is that the methods are defined in a package extension, so the package does not need to be maintained separately.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 166 lines in your changes missing coverage. Please review.

Project coverage is 27.86%. Comparing base (023b1a4) to head (31d9116).
Report is 12 commits behind head on master.

Files Patch % Lines
ext/ApproxFunBaseTestExt.jl 0.00% 166 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #657       +/-   ##
===========================================
- Coverage   75.20%   27.86%   -47.35%     
===========================================
  Files          79       80        +1     
  Lines        8445     8575      +130     
===========================================
- Hits         6351     2389     -3962     
- Misses       2094     6186     +4092     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 6fe969e into master Jun 9, 2024
14 of 16 checks passed
@jishnub jishnub deleted the jishnub/testext branch June 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant