Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kron product on sum spaces #640

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix kron product on sum spaces #640

merged 2 commits into from
Mar 5, 2024

Conversation

mzaffalon
Copy link
Contributor

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (023b1a4) to head (6603ad2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
- Coverage   75.20%   74.30%   -0.90%     
==========================================
  Files          79       79              
  Lines        8445     8446       +1     
==========================================
- Hits         6351     6276      -75     
- Misses       2094     2170      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member

jishnub commented Mar 5, 2024

Thanks! Could you also bump the patch version?

@mzaffalon
Copy link
Contributor Author

mzaffalon commented Mar 5, 2024

You mean Project.toml?

@jishnub
Copy link
Member

jishnub commented Mar 5, 2024

Yes, please update the version to 0.9.26. I will merge and tag a release

@jishnub jishnub merged commit ab9138c into JuliaApproximation:master Mar 5, 2024
15 of 16 checks passed
@mzaffalon
Copy link
Contributor Author

Thank you!

Would you merge also JuliaApproximation/ApproxFunFourier.jl#117 or would you like more tests?

@jishnub
Copy link
Member

jishnub commented Mar 5, 2024

I think that's fine. I'll merge that after backporting this to the v0.8 branch.

jishnub added a commit to jishnub/ApproxFunBase.jl that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong tensor product between Fourier and Chebyshev
2 participants