Move supports_subscribe to AbstractPairing #378
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a check to see if subscribe is broken but checking it depends on the pairing type. Make sure all pairings support this. related issue home-assistant/core#124099
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
Aug 25, 2024
19 tasks
|
In home-assistant/core#124099 we see the connection getting dropped. However the full log is missing so its hard to tell what is really going on there. It may be every time we try to subscribe the device drops the connection and we need to not try again if it failed once as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a check to see if subscribe is broken but checking it depends on the pairing type. Make sure all pairings support this.
related issue home-assistant/core#124099