npm run build throws an error

[bahrus]

I have typescript 3.2.2. When I run npm run build, I get the following error from twsc

AttributeTemplatePart.ts:89:7 - error TS2380: 'get' and 'set' accessor must have the same type.

89 get value(): string {
~~~~~

AttributeTemplatePart.ts:93:7 - error TS2380: 'get' and 'set' accessor must have the same type.

93 set value(value: string | null) {
~~~~~

[Jamesernator]

I am aware of this but the proto-spec seems to allow this (which TypeScript simply doesn't allow):

// Will delete the attribute if it's fully templatized
attributeTemplatePart.value = null

Also note the version in this repository is actually slightly different to the zipped version I posted in this comment, implementing my suggested changes.

In particular the concept of a node template part list is gone and is simply replaced with an anchor tag that keeps track of its own siblings. Additionally "InnerTemplatePart" is no longer a subclass of NodeTemplatePart as some of the properties on NodeTemplatePart didn't make sense for InnerTemplatePart.

Also no global registry of template processors in this version, either (the other has it).

[bahrus]

Thanks for the explanation. I created a pull request in case you find it helpful. Feel free to discard, and close.