Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: KWStyle mishandles template<unsigned> #3143

Closed
Leengit opened this issue Jan 25, 2022 · 2 comments
Closed

BUG: KWStyle mishandles template<unsigned> #3143

Leengit opened this issue Jan 25, 2022 · 2 comments
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Comments

@Leengit
Copy link
Contributor

Leengit commented Jan 25, 2022

Description

If

   template <unsigned int>
   struct Dispatch : public DispatchBase
   {};

is replaced with

   template <unsigned>
   struct Dispatch : public DispatchBase
   {};

then KWStyle gives the error:

Modules/Core/Common/include/itkBSplineDerivativeKernelFunction.h:93: error: Template definition (unsigned) doesn't match regular expression

Expected behavior

KWStyle should permit unsigned in this context of an unsigned template parameter that is unnamed.

Actual behavior

KWStyle gives the error:

Modules/Core/Common/include/itkBSplineDerivativeKernelFunction.h:93: error: Template definition (unsigned) doesn't match regular expression

Reproducibility

100%

Versions

Commit ae8cd25

Environment

  • Linux 5.13.0-27-generic #29~20.04.1-Ubuntu SMP Fri Jan 14 00:32:30 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
  • clang-format version 8.0.0 (tags/RELEASE_800/final)
  • Python 3.8.10
@Leengit Leengit added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Jan 25, 2022
@dzenanz
Copy link
Member

dzenanz commented Jan 26, 2022

This might be in https://github.com/Kitware/KWStyle/issues. Even if not, the fix should go there.

@Leengit
Copy link
Contributor Author

Leengit commented Jan 26, 2022

Closing this issue in favor of Kitware/KWStyle#106.

@Leengit Leengit closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

No branches or pull requests

2 participants