Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor scripts into a CLI #6
base: main
Are you sure you want to change the base?
Refactor scripts into a CLI #6
Changes from 18 commits
5a161d1
a0f6d25
a2d570a
9bfd5c5
53a147d
0f4ef69
fad9b67
dc6f9a2
edc1acb
afec2f8
676477a
344c270
d5d6773
7869894
739b4ff
c0731fa
0715a32
9841170
fe51e6e
3bc2f15
a36d287
744cdac
35c3cd8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underlying image should be cited. I'm still waiting on Christopher for the appropriate licensing and citation for the STRI images (see PR #5).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is the difference between these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first one
--outputs-base-dir
will create a folder for outputs within the specified directory with a unique identifier based on the args passed and dataset processed. Makes it useful for testing parameters like resize and bbox padding and enables thescan-runs
table to give an overview of the outputs within--outputs-base-dir
.The second one
--custom-output-dir
will put outputs directly in the specified directory for more user control.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explanation should probably be added somewhere, so someone else won't have the exact same question.