Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Docker and Acknowledgments Documentation #72

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

johnbradley
Copy link
Collaborator

Adds better explanation to docker instructions.
Fixes #68

Fixes link in Acknowledgments
Fixes #71

Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments for one minor typo, and a question about the arguments to docker run.

docs/docker.md Outdated Show resolved Hide resolved
docs/docker.md Outdated Show resolved Hide resolved
docs/docker.md Outdated Show resolved Hide resolved
docs/docker.md Show resolved Hide resolved
docs/docker.md Outdated Show resolved Hide resolved
@johnbradley johnbradley merged commit d2a1c07 into main Dec 5, 2024
1 check passed
@johnbradley johnbradley deleted the 68-docker-docs branch December 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix predict.py link in Acknowledgments Clarify docker cache directory instructions
2 participants