Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usage of SSSOM-py #666

Merged
merged 19 commits into from
Dec 6, 2023
Merged

Improve usage of SSSOM-py #666

merged 19 commits into from
Dec 6, 2023

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Oct 4, 2023

pyproject.toml Outdated Show resolved Hide resolved
@cthoyt cthoyt marked this pull request as ready for review November 21, 2023 08:16
@cthoyt
Copy link
Collaborator Author

cthoyt commented Nov 21, 2023

looking like it's passing except a spurious bug in the pubmed eutils (unrelated)

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9862ec0) 76.48% compared to head (99d5d84) 76.03%.

Files Patch % Lines
src/oaklib/utilities/mapping/sssom_utils.py 50.00% 2 Missing ⚠️
src/oaklib/interfaces/basic_ontology_interface.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   76.48%   76.03%   -0.46%     
==========================================
  Files         252      252              
  Lines       29386    29368      -18     
==========================================
- Hits        22477    22330     -147     
- Misses       6909     7038     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hrshdhgd hrshdhgd requested a review from cmungall November 29, 2023 23:59
@cmungall
Copy link
Collaborator

cmungall commented Dec 4, 2023

I think this is the correct sequence

  1. Make a separate PR where we pin sssom <0.4.0
  2. Make an OAK release
  3. Make a sssom 0.4.0 release
  4. Modify this PR to be >= 0.4.0 (potentially <0.5.0 if more breaking changes are expected)

I wish python dependencies didn't lead to dependency hell, but here we are

(I just realized I said "dependency hell" on pull number 666, 🤘🤘🤘 😈 😈 😈 )

@hrshdhgd hrshdhgd mentioned this pull request Dec 5, 2023
5 tasks
@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Dec 5, 2023

Bullets 1, 2 and 3 are done. @cthoyt , could you take care of bullet 4 please?

@cthoyt
Copy link
Collaborator Author

cthoyt commented Dec 6, 2023

@hrshdhgd done

@hrshdhgd hrshdhgd merged commit 3322bfd into INCATools:main Dec 6, 2023
5 checks passed
@cthoyt cthoyt deleted the improve-sssom-py branch January 13, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants