Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuning : invalid name for group of parameters, to be changed (neural_net -> neural_net_hparams) #97

Open
CharlesGaydon opened this issue Nov 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@CharlesGaydon
Copy link
Collaborator

CharlesGaydon commented Nov 13, 2023

https://github.com/IGNF/myria3d/blob/2260b080b6b152cd168d5cea86723a77f868dfcc/myria3d/train.py#L30C34-L30C34

This leads to mismatch in model dimensions when loading a pretrained model.

Additionnaly, the required method change_num_class_for_finetuning, that used to be part of the NN module, is not there anymore. This means that finetuning for a different number of classes is not supported (cf. finetuning callbacks)

@CharlesGaydon CharlesGaydon added bug Something isn't working invalid This doesn't seem right and removed invalid This doesn't seem right labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant