Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly #226

Open
ericbn opened this issue Jul 13, 2023 · 1 comment

Comments

@ericbn
Copy link
Contributor

ericbn commented Jul 13, 2023

Hi 👋

Using hubspot-api-client 8.0.0 and urllib3 1.26.16, I get these warnings:

hubspot/crm/contacts/rest.py:41: DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.
  return self.urllib3_response.getheaders()
hubspot/crm/contacts/rest.py:45: DeprecationWarning: HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTPResponse.headers.get(name, default).
  return self.urllib3_response.getheader(name, default)

These warnings also come from:

hubspot/communication_preferences/rest.py:41
hubspot/communication_preferences/rest.py:45
hubspot/crm/associations/rest.py:45
hubspot/crm/deals/rest.py:45
hubspot/crm/objects/rest.py:45
hubspot/discovery/discovery_base.py:1

and so on...

See other deprecations with urllib3 2.0.0 here. And urllib3 2.1.0 is planned to be released in the summer of 2023.

Resolving these deprecation warnings will prepare hubspot-api-client to be ready for future versions of urllib3. A plan for package maintainers is described here.

I'll be happy to contribute with a PR. Regarding the maintenance of the project, I see most files have Generated by: https://openapi-generator.tech, but I don't see instructions on how to regenerate those files. To fix the issue mentioned here, should we regenerate the files with an updated OpenAPI Generator?

@ericbn
Copy link
Contributor Author

ericbn commented Nov 17, 2023

Hi. FYI urllib3 version 2.1.0 was just released 4 days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant