Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casks with :extract_plist livecheck strategy #171006

Open
krehel opened this issue Apr 10, 2024 · 3 comments
Open

Casks with :extract_plist livecheck strategy #171006

krehel opened this issue Apr 10, 2024 · 3 comments
Labels
help wanted

Comments

@krehel
Copy link
Member

krehel commented Apr 10, 2024 •
edited by khipp
Loading

Livechecks with :extract_plist strategy should only be used as a last resort to get version information. This sometimes means downloading very large applications in order to extract version information, which is not ideal. Applications over time may have evolved to having better information available, so it would be great to check if :extract_plist is necessary.

Ideally, :extract_plist should probably only be used when:

  1. Version information is truly not available via any other means
  2. Application has another means to get information, but may be complicated to utilize AND the application is small in terms of download size.

For the below mentioned Casks...

  1. Verify if :extract_plist strategy is still needed, or if an alternative strategy can be used. Any alternative means would be acceptable as long as it is a reliable method.
  2. If the Cask cannot use any other method, please mention in a comment including why the Cask should remain as :extract_plist so it may be checked off the list with no changes needed.
  3. Update the Cask with the other livecheck method, and open a PR for review, and mention the PR in a comment in this issue for tracking.
  4. If other changes need to be made to the Cask, such as a version update, adding ARM support, adding auto_updates etc, please make those changes as part of the PR.
  5. If the Cask is no longer offered, is moved to the Mac App Store, or is otherwise no longer developed, please open a PR to mark as deprecated for Homebrew Maintainers to consider.
  6. If you need help, please feel free to mention me here or in a PR.
@SMillerDev SMillerDev changed the title [Task | Help Wanted] Casks with :extract_plist livecheck strategy Casks with :extract_plist livecheck strategy Apr 10, 2024
@chenrui333 chenrui333 mentioned this issue Apr 20, 2024
Merged
@razvanazamfirei razvanazamfirei mentioned this issue Apr 20, 2024
Merged
@krehel krehel mentioned this issue Apr 23, 2024
Merged
@adithyasunil26 adithyasunil26 mentioned this issue Apr 24, 2024
Closed
3 tasks
@adithyasunil26
Copy link
Contributor

adithyasunil26 commented Apr 24, 2024 •
edited
Loading

  • The following casks do not mention the version details anywhere so they will need to keep using the :extract_plist:
    • avg_antivirus
    • chrome-remote-desktop-host
    • webex
    • teensy
    • surfshark
    • send-to-kindle
    • purevpn
    • nvidia-geforce-now
    • hp-easy-admin
    • hp-easy-start
    • megasync
    • bankid
  • garmin-express mentions the latest version on their support page here but it is mentioned as 7.20.0 instead of 7.20.0.0 and it doesn't seem to be possible to curl that part of the page as it is loaded in with javascript. Any ideas on how we can go about this? (Not an expert at webdev)
  • boom metnions the latest version here but the second part of the version isn't. Is it ok to work with just the primary version number and ignore the second part?
  • circuitjs1 livecheck updated in circuitjs1: update livecheck #172055

@samford samford mentioned this issue May 23, 2024
Merged
9 tasks
This was referenced May 31, 2024
Merged
Closed
This was referenced Jul 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@khipp
Copy link
Member

khipp commented Jul 5, 2024 •
edited
Loading

recordit has been disabled in #171014.

This was referenced Jul 5, 2024
Merged
Merged
This was referenced Aug 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@khipp khipp mentioned this issue Oct 16, 2024
Merged
8 tasks
@daeho-ro daeho-ro mentioned this issue Oct 20, 2024
Merged
8 tasks
This was referenced Oct 27, 2024
Merged
Merged
Merged
Merged
Closed
Merged
@khipp khipp mentioned this issue Nov 15, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SMillerDev @khipp @krehel @adithyasunil26