Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www/node: Use binutils from ports with BUNDLED_SSL #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xmj
Copy link
Member

@xmj xmj commented Jun 11, 2018

www/node does not work well with with BUNDLED_SSL
when DTRACE is on (default) and we are using an older
binutils version. FreeBSD is using the last GPLv2 one,
which does not provide options expected by a few python
scripts.

Use ports binutils and patch python scripts to use it.

Signed-off-by: Johannes Meixner [email protected]

@xmj
Copy link
Member Author

xmj commented Jun 11, 2018

Similar issues on other operating systems:

nodejs/node#1967
nodejs/node#7840
nodejs/node#8937

@xmj xmj assigned xmj and Sp1l Jun 11, 2018
@Sp1l
Copy link
Member

Sp1l commented Jun 11, 2018

Apart from the SHEBANG_FILES this looks OK to me

www/node does not work well with with BUNDLED_SSL
when DTRACE is on (default) and we are using an older
binutils version. FreeBSD is using the last GPLv2 one,
which does not provide options expected by a few python
scripts.

Use ports binutils and patch python scripts to use it.

Signed-off-by:	Johannes Meixner <[email protected]>
@xmj xmj force-pushed the bugfix/www_node__binutils branch from 04e724a to 3854818 Compare June 12, 2018 04:19
@xmj
Copy link
Member Author

xmj commented Jun 12, 2018

Nice catch! Amended and rebased to latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants