Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tslc to be a boolean array in get_correction_factor_from_cov() #981

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

jsdillon
Copy link
Member

This helps us handle baselines with flagged holes in their time series (a rare case that mostly only affects low-redundancy baseline groups).

@jsdillon jsdillon requested a review from mwilensky768 October 28, 2024 18:54
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (7544b60) to head (fcddd06).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   97.19%   97.20%           
=======================================
  Files          31       31           
  Lines       11141    11146    +5     
=======================================
+ Hits        10829    10834    +5     
  Misses        312      312           
Flag Coverage Δ
unittests 97.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsdillon jsdillon merged commit a959d59 into main Oct 28, 2024
9 checks passed
@jsdillon jsdillon deleted the tslc-boolean-array branch October 28, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants