Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose option #979

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add verbose option #979

merged 2 commits into from
Oct 23, 2024

Conversation

mwilensky768
Copy link

This is just adding a verbose option to a preparation function for error propagation. Just trying to avoid unnecessarily printing 6 bajillion times.

@mwilensky768 mwilensky768 requested a review from jsdillon October 21, 2024 22:08
Copy link
Member

@jsdillon jsdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.19%. Comparing base (d82cd84) to head (f949ea7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
hera_cal/frf.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   97.20%   97.19%   -0.01%     
==========================================
  Files          31       31              
  Lines       11140    11141       +1     
==========================================
  Hits        10829    10829              
- Misses        311      312       +1     
Flag Coverage Δ
unittests 97.19% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsdillon jsdillon merged commit 5b982b0 into main Oct 23, 2024
7 of 9 checks passed
@jsdillon jsdillon deleted the verbose_frop_hotfix branch October 23, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants