Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does really this is a data from that grocery list? #197

Open
atherdon opened this issue Jan 28, 2019 · 5 comments
Open

does really this is a data from that grocery list? #197

atherdon opened this issue Jan 28, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@atherdon
Copy link
Member

atherdon commented Jan 28, 2019

react app
Real data.
https://github.com/GroceriStar/groceristar-fetch/blob/master/data/Ingredients/how-i-spent-40-at-trader-joes-and-ate-healthy-for-a-week.json

I assume it's a good time or sign that we need to think about having one source of all data and then just pass it into small components.
We should start from fetch plugin.

@vadim9999
Copy link
Collaborator

vadim9999 commented Feb 3, 2019

I don't know maybe someone change first letter(from small to big) department name in ingredients.json or in grocery department. and for this reason you get this bug. Now in ingredients.json

{
    "name": "Air freshener",
    "department": "Other"
  },
  {
    "name": "Bathroom cleaner",
    "department": "Other"
  },
  {
    "name": "Bleach  Detergent",
    "department": "Other"
  },
  {
    "name": "Dish  Dishwasher soap",
    "department": "Other"
  },
  {
    "name": "Garbage bags",
    "department": "Other"
  },
  {
    "name": "Glass cleaner",
    "department": "Other"
  },
  {
    "name": "Mop head  Vacuum bags",
    "department": "Other"
  },
  {
    "name": "Sponges  Scrubbers",
    "department": "Other"
  },

but department in grocery how-i-spent-40-at-trader-joes-and-ate-healthy-for-a-week is "other" (small letter) then I have opened this tile and list of ingredient is empty.
image

I think our need rebase mathods that finds ingredients by department. Now it's searching in ingredients.json but needs to connect other ingredients json. I think we can grab all ingredients that we have and push in one very big array. Or can search ingredients for one department related to one grocery.
For example we have grocery how-i-spent-40-at-trader-joes-and-ate-healthy-for-a-week and we will serach ingredients from how-i-spent-40-at-trader-joes-and-ate-healthy-for-a-week.json

@atherdon
Copy link
Member Author

atherdon commented Feb 3, 2019

let's choose different path.
we have a new method that return all grocery lists. When we'll add tests and confirm that everything works file - let's use it in showcase. what do you think about this plan? again - i think we(you or me, this is how actually this bugs appears) change something at our methods and things goes to crash. I don't think that this is a problem. I just want to have a place, where we can test what we done.

Tell me if you agree with me

@vadim9999
Copy link
Collaborator

Ok

@atherdon
Copy link
Member Author

atherdon commented Feb 3, 2019

i think this issue is partially related to work, that Maria did, so we'll move this question to fetch plugin and ask her, when she have time

@atherdon
Copy link
Member Author

atherdon commented Feb 3, 2019

btw, at http://localhost:3000/home2 you can see how cards are rendered without styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants