Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entity data table to security events #21091

Merged
merged 15 commits into from
Dec 11, 2024

Conversation

maxiadlovskii
Copy link
Contributor

@maxiadlovskii maxiadlovskii commented Dec 2, 2024

Description

This PR prepares existing code and adds some reusable parts to be able to use the entity data table on the security events page. Also, adds a feature flag

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

/nocl

@maxiadlovskii maxiadlovskii marked this pull request as ready for review December 4, 2024 19:45
},
event_definition_type: {
renderCell: (_type: string) => <EventDefinitionTypeRenderer type={_type} />,
staticWidth: 200,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove _ from these variable names.

@linuspahl linuspahl merged commit a18ee23 into master Dec 11, 2024
7 checks passed
@linuspahl linuspahl deleted the feat/Use-entity-dta-table-in-security-events branch December 11, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants