-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix line wrapping in sidecar default configs for filebeat #21043
Conversation
@AntonEbel, do you have any idea why this was broken? I'm pretty sure the configs were tested when they were added. Also, I only tested the Darwin configs. It would be great if you could give the other configs a quick test. |
...c/main/java/org/graylog/plugins/sidecar/migrations/V20180212165000_AddDefaultCollectors.java
Outdated
Show resolved
Hide resolved
If the user has not changed the broken configurations, the “checksum migration” should work and we would replace them with the working configurations. Or am I wrong? @thll |
Just for traceability, this bug came in with #15571. The configurations were provided by secdev in this PR https://github.com/Graylog2/graylog-project-illuminate/issues/1384. |
Right, if they didn't touch the config then it will be repaired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sidecar default configuration templates for filebeat have the line wrapping messed up. For new clusters, or clusters that don't have the default templates present, invalid configuration will be created. See the following preview:
This PR fixes that by modifying the templates for newly created configurations. After applying the PR, the default configuration from above should look like this:
However, this won't fix existing configurations.