Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: support more package managers #11

Open
Un1q32 opened this issue Feb 24, 2023 · 9 comments
Open

Windows: support more package managers #11

Un1q32 opened this issue Feb 24, 2023 · 9 comments
Labels
enhancement New feature or request hacktoberfest 🍻 libmacchina Requires a change in libmacchina

Comments

@Un1q32
Copy link
Contributor

Un1q32 commented Feb 24, 2023

it runs but theres no logo, os detection, or package count
memory, uptime, and kernel work though
Screenshot 2023-02-24 152053

@Gobidev
Copy link
Owner

Gobidev commented Feb 24, 2023

I fixed os and host detection in ab02f3c. There is currently no logo because pfetch does not have one for Windows. I will probably try to make one but my ASCII art skills are not the best. Package count could probably work with chocolatey or winget, trying to count the packages installed otherwise would be too unreliable.

Gobidev added a commit that referenced this issue Feb 24, 2023
@Gobidev
Copy link
Owner

Gobidev commented Feb 24, 2023

image
I added a simple logo, this is what pfetch now looks like on Windows.

@Gobidev
Copy link
Owner

Gobidev commented Feb 24, 2023

39785f1: I now use libmacchina for Windows package count, which currently supports cargo and scoop. I may try to add support for winget and chocolatey in the future.

@Un1q32
Copy link
Contributor Author

Un1q32 commented Feb 24, 2023

i recommend using # for the windows logo instead of l

@Gobidev
Copy link
Owner

Gobidev commented Feb 25, 2023

You are right, that looks better. As of 5d037c5 it now looks like this:

image

@Gobidev Gobidev added the enhancement New feature or request label Feb 27, 2023
@Gobidev Gobidev self-assigned this Feb 27, 2023
@Gobidev
Copy link
Owner

Gobidev commented Mar 9, 2023

Added Windows binary in v2.2.0

@Gobidev Gobidev closed this as completed Mar 9, 2023
@Un1q32
Copy link
Contributor Author

Un1q32 commented Mar 15, 2023

Could you add support for pacman with msys2? I can't imagine it would be too difficult since pacman works with arch linux, and its the same on msys2

@Gobidev Gobidev reopened this Mar 16, 2023
@Gobidev Gobidev changed the title Windows support? Support for msys2 pacman package count Mar 16, 2023
@Gobidev Gobidev removed their assignment Mar 16, 2023
@Gobidev Gobidev changed the title Support for msys2 pacman package count Windows support Mar 16, 2023
@Gobidev Gobidev added the libmacchina Requires a change in libmacchina label Mar 16, 2023
@Gobidev
Copy link
Owner

Gobidev commented Mar 21, 2023

I did some testing and it is actually not that difficult, but it would requre a change in libmacchina and it is possible that this is too much of a niche usecase to be added. I will make a PR soon and we'll see.

@Un1q32
Copy link
Contributor Author

Un1q32 commented Mar 21, 2023

I wouldn't call this niche. MSYS2 is how people get any unix-like CLI things working on Windows without WSL (like if you run windows 8)

@Gobidev Gobidev changed the title Windows support Windows: support more package managers Mar 24, 2023
@Gobidev Gobidev added the hacktoberfest 🍻 label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest 🍻 libmacchina Requires a change in libmacchina
Projects
None yet
Development

No branches or pull requests

2 participants