-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog support for smart-release (continuation 2) #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which comes with the benefit of not needing to be parsed back at all. We will just treat it as marker when parsing, knowing that it will be replaced with the same (or updated) information during merge. This allows to create more elaborate statistics without adding effort to parse this back - this effort is spent exlusively where it matters, with the git-conventional sections that are in fact user-editable.
…to help handling parsed/statistical/read-only types even better
…instead of also avoiding the changelog to be written. Otherwise statistics wouldn't be updated if its not rewritten. Now that only drives whether or not we get to preview a changelog, which won't happen if there is nothing relevant, like statistics or headline changes.
…parsing really needs a headline and it's probably ok to provide it. Otherwise parsing would be more complicated and it shouldn't be that way now.
…as the latter is hard to keep in line with the markdown, especially if it's markdown itself. Instead, people can click the commit link that github will auto-generate.
…as they forgot to turn off gpg signing.
…which changed due to larger changelogs.
…and learn that the top-level crate definitely needs another approach for details as it simply is affected by all commits.
Previously when accessing a packed object, it would store the base object into the pack cache (if it wasn't retrieved from there) which is great if that operation is free. Since it isn't, it's better not to stress the cache with puts and trash more objects than necessary. Now only the last decompressed object will be put into the LRU cache.
This really helps with conveniently adjusting the changelog to your needs.
…even though it's not working correctly judging by a few samples.
…to enable dealing with parent lookups specifically.
…which fixes an over-abundance of commits showing up in the details section even though they didn't actually contribute.
…for some more absolute order of what we would have gotten otheriwse.
…and verify that unparsable inbetweens are bound to their closest parseable headline.
…with it being added only if there is no other section present yet. That way changelogs can be configured intuitively.
With it one can omit auto-generated sections of the given name.
…to allow disabling various changelog segments like clippy, or commit statistics. Note that it's always possible to delete individual sections afterwards.
…which reveals a lot of issues with a few core pieces of logic. Nothing terrible, but some tests need to be written to nail it.
Rollup changes from a week to avoid long-running PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #198.
gh release create
- it supposedly pulls contents from tag objects, but it should be easy to pass them. More information here.After merge, release and fix #204, and setup install validation for smart-release.
ByteVec
consuming trait methods on BString fails with "cannot move out of dereference of BString" BurntSushi/bstr#98Commit::footers()
andCommit::breaking_description()
use lifetime of message… crate-ci/git-conventional#16