Feature adaptive selection #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding module builders.py containing abstract class BacktestItemBuilders and child classes SelectionItemBuilder andOptimizationItemBuilder as well as various backtest item builder functions (bibfn)
- Adding functions append_custom and output_to_strategies to helper_functions.py - Adjustment in data_loader.py
- Adding class BacktestService and adjustments in class Backtest. Adjustment in related helper functions. - Adding test/demo file quick_and_dirty_interactive_testing.
- Adding module mean_estimation
vfisikop
reviewed
Oct 25, 2024
|
|
||
|
|
||
| ############################################################################ | ||
| ### QUICK-AND-DIRTY TESTING IN INTERACTIVE MODE DURING DEVELOPMENT |
There was a problem hiding this comment.
Maybe a better place for this file is in test directory.
There was a problem hiding this comment.
I would move it to examples, since this is a quick-and-dirty example of how one could run the (additional) code.
| @@ -1,103 +0,0 @@ | |||
| # GeoFin : a python library for portfolio optimization and index replication | |||
There was a problem hiding this comment.
it is not clear if the functionality of this file is moved to some other file or totally removed
TolisChal
approved these changes
Nov 15, 2024
|
Thanks @cbachela! I left one minor comment. Otherwise looks good to me. I approved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.