Bug: 500 on Early Submission

[jperson1]

When a user navigates to submission before the previous steps have been completed, a 500 is thrown. See report 2022-06-GSAFAC-0000063734 for an example. How to recreate this locally:

• Get a submission up to the point where the cross validation passes and copy the report_id
  • A quick way is to comment out lines 102-139 in full-submission.js, and run the test. Make sure your own login is the auditee certifying official so that you can do the submission.
• Head to http://localhost:8000/audit/submission/<report_id>
• Click submit and it should 500

When a user attempts to mark a submission "ready for certification" while it is already in that state. See report 2024-06-GSAFAC-0000065085 for an example.

Stack trace for the first case:

Traceback (most recent call last):
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/newrelic/hooks/framework_django.py", line 527, in wrapper
    return wrapped(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/app/audit/mixins.py", line 91, in dispatch
    return super().dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/django/contrib/auth/mixins.py", line 73, in dispatch
    return super().dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/newrelic/hooks/framework_django.py", line 900, in wrapper
    return wrapped(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vcap/app/audit/views/views.py", line 717, in post
    sac_transition(request, sac, transition_to=STATUS.SUBMITTED)
  File "/home/vcap/app/audit/models/viewflow.py", line 82, in sac_transition
    flow.transition_to_submitted()
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/viewflow/fsm/base.py", line 229, in __call__
    with TransitionBoundMethod.Wrapper(self, kwargs=kwargs):
  File "/home/vcap/deps/1/python/lib/python3.12/site-packages/viewflow/fsm/base.py", line 154, in __enter__
    raise TransitionNotAllowed(
viewflow.fsm.base.TransitionNotAllowed: Transition_To_Submitted :: no transition from "in_progress"

Tasks

Tasks

Beta Give feedback

1. Move to a 400 "Bad Request" when trying to transition from the wrong state.
2. Move to a 400 "Bad Request" when trying to transition to the same state it's already in.