Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📍 Rebase cog/over #4402

Open
1 of 3 tasks
danswick opened this issue Oct 21, 2024 · 3 comments
Open
1 of 3 tasks

📍 Rebase cog/over #4402

danswick opened this issue Oct 21, 2024 · 3 comments

Comments

@danswick
Copy link
Contributor

danswick commented Oct 21, 2024

This is a placeholder for tracking work related to rebasing our cognizant / oversight assignments.

Tasks

Tasks

  1. eng
    gsa-suk
@github-project-automation github-project-automation bot moved this to Triage in FAC Oct 21, 2024
@danswick danswick moved this from Triage to Backlog in FAC Oct 21, 2024
@gsa-suk
Copy link
Contributor

gsa-suk commented Oct 30, 2024

Questions related to rebasing:
Added answers for 1 and 2 based on discussion with @danswick on 11/01/24

  1. Current base year is 2019. When does the base year change to 2024? - 2024 audit year.
  2. How far can re-submissions go? Do multiple base years have to be supported by FAC? - Yes (for now. Verify with OMB)
  3. Base years are 2019, 2024 and every fifth year thereafter.
    For base year of 2019, cog assignment year range is 2021 - 2025, based on data in cogreflist.csv from Census.
    Is the cog assignment year correct?
    What does it mean?
    What is the cog assignment year range associated with base year 2024 and future base years?
  4. What are the changes to the current algorithm / flowchart?
  5. Will the cog_ref_list for 2024 base year and future base years be provided or calculated by GSAFAC?

@gsa-suk gsa-suk assigned gsa-suk and unassigned gsa-suk Nov 1, 2024
@danswick
Copy link
Contributor Author

Capturing some notes from discussion with @gsa-suk and @gsa-jrothacker:

  1. Let's explore capturing all the business logic in code rather than in tables. If we can jettison both the assignment tables, let's do it and rely on the submission record itself.
  2. If the above looks good, we should be able to write more complete unit tests for COG / OVER assignment.
  3. The rest of the assignment logic should still be valid (the flowchart).
  4. I think there was one more thing, but it's escaping me.

@gsa-suk
Copy link
Contributor

gsa-suk commented Nov 25, 2024

The audit_year, baseline year mapping is as follows:
<style type="text/css"></style>

audit_year base_year
2019 2019
2020 2019
2021 2019
2022 2019
2023 2019
2024 2024
2025 2024
2026 2024
2027 2024
2028 2024
2029 2029
2030 2029
2031 2029
2032 2029
2033 2029
2034 2034
2035 2034
2036 2034
2037 2034
2038 2034
2039 2039
2040 2039
2041 2039
2042 2039
2043 2039
....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants