Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature for WebAssembly reference types #6952

Merged
merged 5 commits into from
Feb 17, 2024
Merged

Conversation

dschuff
Copy link
Contributor

@dschuff dschuff commented Jan 26, 2024

This is a post-MVP feature extension for WebAssembly. Since its launch, several such extensions have been added to the standard and shipped in browsers. See https://github.com/WebAssembly/proposals and https://webassembly.org/features/

If this example is accepted, I will add additional entries for the other finished and/or in-progress wasm extensions.

Most features can be detected conveniently from https://webassembly.org/features/ (the "Your browser" column in the table shows support for the current browser) which is backed by the wasm-feature-detect library at https://github.com/GoogleChromeLabs/wasm-feature-detect

See also #5687

This is a post-MVP feature extension for WebAssembly. Since its launch,
several such extensions have been added to the standard and shipped in
browsers. See https://github.com/WebAssembly/proposals and
https://webassembly.org/features/

If this example is accepted, I will add additional entries for the
other finished and/or in-progress wasm extensions.
@dschuff
Copy link
Contributor Author

dschuff commented Jan 26, 2024

I have a couple of open questions here that I hope a reviewer can help me with.
One is that the specifications for webassembly feature extensions begin their life with an informal-but-detailed overview, written in markdown, which describes the feature in terms of what it adds on top of the existing spec. But when the formal spec is written, it begins as a fork of the full spec with all wasm features to date, and ends by being merged into the full spec. So there's no full formal spec with just the single feature in it; maybe that doesn't matter? Also the overview is likely going to be more useful and understandable for most people anyway. Here I made the "spec" URL be the full formal spec, and also added a link to the overview in addition, but I'm open to other approaches here.

Another question is the category. Right now the base wasm page and this one have categories of "Other" but it might make sense to actually give Wasm its own category, since we expect to keep adding features over time, similarly to JS.

And finally, I was unsure what to put as the "parent" feature. I just guessed and put "wasm".

@dschuff
Copy link
Contributor Author

dschuff commented Feb 16, 2024

Who should take a look at this? Maybe @Fyrd can, or can suggest someone?

@Fyrd
Copy link
Owner

Fyrd commented Feb 17, 2024

Thanks, I'm okay accepting this and similar entries. Fixed a few issues, though one remaining one is a missing description, would you mind including one?

Not too concerned about the specification, whatever seems most helpful to people, I'm fine with using the overview.

As for the category, let's stick with "Other" for now, will consider a dedicated category in the future.

Thanks again!

@dschuff
Copy link
Contributor Author

dschuff commented Feb 17, 2024

Done, thanks!. I'll hopefully get a chance to add more wasm features next week.

@Fyrd Fyrd merged commit 5a2757a into Fyrd:main Feb 17, 2024
1 check passed
@Fyrd
Copy link
Owner

Fyrd commented Feb 17, 2024

Thanks!

@Fyrd
Copy link
Owner

Fyrd commented Feb 17, 2024

@dschuff I notice you included Edge 16-18 as supporting this feature, which was pre-Chromium Edge. Are you sure those versions have support?

@dschuff
Copy link
Contributor Author

dschuff commented Feb 20, 2024

Ah good catch, that may have been a copypasta. Pre-chromium Edge supported MVP wasm but I don't think it supported any extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants