Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

fix firewall to answer all login entry points #158

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

fix firewall to answer all login entry points #158

wants to merge 31 commits into from

Conversation

bitgandtter
Copy link

...ing for facebook auth

@stof
Copy link
Member

stof commented Jul 4, 2012

I don't understand why it should authenticate the user only when there is no query string. Thus, this will still authenticate for most pages.

@bitgandtter
Copy link
Author

In the case that you have multiple authentication providers like the FOSTwitterBundle and Google or other OAth2 the entry point that its defined first in the firewall will response to the authentication process. Here an example of a firewall:

firewalls:
main:
pattern: ^/
form_login:
provider: fos_userbundle
csrf_provider: form.csrf_provider
logout: true
anonymous: true
fos_facebook:
app_url: http://apps.facebook.com/sunnynews/
server_url: http://sunnynews.com/app_dev.php/
provider: facebook
fos_twitter:
provider: twitter
fos_google:
provider: google

in this case twiitter never authenticate the user without this condition because facebook provider always answer.

Maybe the condition need some work or extra validation, but with it if the authentication process dont have a query string then it leave the process and the next entry point in the firewall will intercept it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants