fix: avoid edge cases with eager loading (#116)

FriendsOfFlarum · Dec 12, 2023 · 9d70b61 · 9d70b61
1 parent ea3231b
commit 9d70b61
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/LoadActorVoteRelationship.php b/src/LoadActorVoteRelationship.php
@@ -40,12 +40,12 @@ public static function sumRelation($controller, $data): void
         } elseif ($data instanceof Collection) {
             $loadable = (new Post())->newCollection($data->map(function ($model) {
                 return $model instanceof Discussion ? ($model->mostRelevantPost ?? $model->firstPost) : $model;
-            }));
+            })->filter());
         } elseif ($data instanceof Post) {
             $loadable = $data->newCollection([$data]);
         }
 
-        if ($loadable) {
+        if ($loadable && $loadable instanceof Collection) {
             $loadable->loadSum('actualvotes', 'value');
         }
     }