Implement WebdriverClassicDriver factory

[uuf6429]

Implements the driver at https://github.com/minkphp/webdriver-classic-driver
Fixes minkphp/webdriver-classic-driver#15

[aik099]

Approving, because all points from my previous review were addressed.

[benr77]

If I use webdriver-classic: in behat.yml then I get the following error:

Unrecognized option "webdriver_classic" under "testwork.mink.sessions.default". Did you mean "webdriver-classic"?

But this is reporting that I do what I have done. It looks like somewhere the hyphen is being replaced by an underscore.

Solution is to change the hyphen to an underscore here

[aik099]

@benr77 , I'm new to Behat. Please describe the steps needed to create a test project with Behat + MinkExtension + this PR code so that it's easier to diagnose the problem. Yaml itself doesn't prohibit hyphen usage inside the key names.

[uuf6429]

@benr77 @aik099 The other drivers are using underscores instead of dashes. It probably makes sense to do it that way, if anything just to keep it consistent.

As to the buggy behaviour, I don't feel like investigating another thing that will take ages to be accepted. 🤷

[benr77]

This underscore fix is now working as expected. Thank you. Hopefully this PR can get merged soon.

[aik099]

FYI: The webdriver-classic in YAML becoming webdriver_classic in PHP is part of the normalization process done by the used Symfony/Config Component: https://symfony.com/doc/current/components/config/definition.html#normalization

The separator used in keys is typically _ in YAML and - in XML. For example, auto_connect in YAML and auto-connect in XML. The normalization would make both of these auto_connect.

[claudiu-cristea]

Landed here trying to use minkphp/webdriver-classic-driver with my Behat setup. @benr77, could you share a behat.yml that uses this PR+minkphp/webdriver-classic-driver?

[benr77]

@claudiu-cristea All I have is this behat.yaml, alongside using this branch instead of main - the important bit is using webdriver_classic.

default:
  suites:
    default:
      contexts:
        - FeatureContext
  extensions:
    Behat\MinkExtension:
      base_url: http://php
      browser_name: chrome
      sessions:
        default:
          webdriver_classic:
            browser: chrome
            wd_host: http://chrome:4444/wd/hub
            capabilities:
              browserName: chrome
              platform: any
              chrome:
                switches:
                  - '--headless'
                  - '--window-size=1200,1100'
                  - '--disable-gpu'
                  - '--no-sandbox'