Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for brother-ql-inventree #23

Open
FriedrichFroebel opened this issue Oct 11, 2024 · 3 comments
Open

Provide support for brother-ql-inventree #23

FriedrichFroebel opened this issue Oct 11, 2024 · 3 comments
Labels
dependencies Changes related to dependencies enhancement New feature or request

Comments

@FriedrichFroebel
Copy link
Owner

At the moment, the package requires brother-ql, which is more or less unmaintained. We should evaluate supporting brother-ql-inventree as well: https://pypi.org/project/brother-ql-inventree/

The biggest issue is that they both use the same namespace, thus possibly creating issues or breaking changes:

  • The "backend" library is always an extra. This is a breaking change as an extra has to specified in all cases.
  • Just brother-ql-inventree is an extra. This creates annoying conflicts as both backend packages would be installed in the same environment, but their code overwriting each other (depending on the installation order). Uninstalling one of them would break both with the current pip logic.
@FriedrichFroebel FriedrichFroebel added enhancement New feature or request dependencies Changes related to dependencies labels Oct 11, 2024
@chrismaster
Copy link

Also from the inventree project
Renaming to brother-ql2
https://pypi.org/project/brother-ql2/
and detached fork
https://github.com/matmair/brother_ql2

@FriedrichFroebel
Copy link
Owner Author

FriedrichFroebel commented Oct 29, 2024

Are there any informations available on what the differences and maintenance concepts of both of these variants are?

@FriedrichFroebel
Copy link
Owner Author

Corresponding issue: matmair/brother_ql-inventree#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes related to dependencies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants