Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux.params is broken #2533

Open
mcabbott opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2509
Open

Flux.params is broken #2533

mcabbott opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2509
Labels
Milestone

Comments

@mcabbott
Copy link
Member

mcabbott commented Nov 25, 2024

I know it's not really supported, but params is more broken than it should be (on master):

julia> Flux.params([2,3])
ERROR: UndefVarError: `IdSet` not defined

julia> @eval Flux using Base: IdSet

julia> Flux.params([2,3])
Params([[2, 3]])

It should probably print friendly upgrade instructions, @warn "..." maxlog=1. People calling this are probably struggling to update old code, and we should help them along.

@mcabbott mcabbott added the bug label Nov 25, 2024
@CarloLucibello CarloLucibello added this to the v0.15 milestone Nov 25, 2024
mcabbott added a commit to mcabbott/Flux.jl that referenced this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants