-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore open-ended ranges in KotlinMixins.kt
(to help with Kotlin 1.7.20+)
#582
Comments
This commit also temporarily changes a test assertion for the Jackson Kotlin module. As of https://youtrack.jetbrains.com/issue/KT-52932, Kotlin enhanced the `IntRange` and this change is not supported yet by the Jackson Kotlin module. An issue has been reported here: FasterXML/jackson-module-kotlin#582 Closes gh-29225
@poutsma @Spikhalskiy Looks like we have two PRs -- #583 and #589 -- solving this. To me #583 looks preferable but wanted to see WDYT. Would be happy to merge either one but preferably while someone else sanity checks the fix (I have no specific concerns but as the general procedure). |
KotlinMixins.kt
KotlinMixins.kt
(to help with Kotlin 1.7.20+)
Fixed via #583, will go in 2.14.0-rc3 |
I will also backport this in 2.13 (for 2.13.5) -- partly to get CI not to fail against |
I can confirm that this is fixed in 2.14.0-rc3. Thanks! |
This commit upgrades Jackson to 2.14.0-rc3, which resolves two outstanding issues Spring Framework had with rc2. This commit reverts the changes made due to those issues, see FasterXML/jackson-core#824, and FasterXML/jackson-module-kotlin#582. Closes gh-29405
Thank you for confirming @poutsma ! |
Kotlin 1.7.20 introduced "Open-ended ranges", see https://youtrack.jetbrains.com/issue/KT-52932.
As a consequence, writing a Kotlin
Range
now writes not just thestart
andend
properties, but alsoendExclusive
.To Reproduce
will print out
{"start":1,"end":3,"endExclusive":4}
.Expected behavior
The above code should print out
{"start":1,"end":3}
.Versions
Kotlin: 1.7.20
Jackson-module-kotlin: 2.13.4
Jackson-databind: 2.13.4
Suggested solution
Add
@JsonIgnore abstract public fun getEndExclusive(): T
toKotlinMixins.kt
The text was updated successfully, but these errors were encountered: